-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2314 - Send asset state hash in heartbeat, implement c2 asset sync #1751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fyi there are still some build issues in the CI
#include "utils/file/FileUtils.h" | ||
#include "utils/file/AssetManager.h" | ||
|
||
class FileProvider : public ServerAwareHandler { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting for visibility that this will cause some conflict with #1749
@adamdebreceni could you check out the the C2AssetSyncTest failure on windows? |
17b1567
to
3ab1ce5
Compare
be322ec
to
f9d1871
Compare
36fccc9
to
a791873
Compare
16a3eda
to
d32136b
Compare
Co-authored-by: Martin Zink <martin.zink@protonmail.com>
Co-authored-by: Martin Zink <martin.zink@protonmail.com>
Co-authored-by: Martin Zink <martin.zink@protonmail.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
ddbddf5
to
116c920
Compare
Co-authored-by: Márton Szász <szaszm@apache.org>
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.